-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ClearFeature(ENDPOINT_HALT) #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miek
force-pushed
the
clear_endpoint_halt
branch
from
June 21, 2024 09:40
eed631f
to
26bd07f
Compare
miek
force-pushed
the
clear_endpoint_halt
branch
from
June 21, 2024 10:23
26bd07f
to
f787ef7
Compare
mndza
reviewed
Jul 5, 2024
mndza
reviewed
Jul 5, 2024
mndza
reviewed
Jul 5, 2024
mndza
requested changes
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've tested it and seems to work fine. I like the use of amaranth.lib.data
. Just added a few minor comments about style.
Thanks! I've made those changes. |
mndza
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in draft until greatscottgadgets/python-usb-protocol#45 makes it into a release (and it probably needs a bit of cleanup), but it should work as-is for testing in the meantime.This implements ClearFeature(ENDPOINT_HALT) as required by the USB 2.0 standard, I've also added an applet that can be used to test it out.