[Draft][EC82] Variable can be made constant

[jpreisner]

• PR ecocode : [Draft][EC82][Java] Variable can be made constant creedengo-rules-specifications#328
• PR ecocode-java-test-project : https://github.com/green-code-initiative/ecoCode-java-test-project/pull/29

[jpreisner]

Point de blocage : au moment de lancer l'analyse sonar sur le projet test, on a l'erreur suivante car la nouvelle Rule utilise du code provenant de la lib java-frontend de sonar.

[ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar (default-cli) on project ecocode-java-plugin-test-project: Execution default-cli of
 goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar failed: A required class was missing while executing org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184:sonar: org/sonar/java/model/ModifiersUtils
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>org.sonarsource.scanner.maven:sonar-maven-plugin:3.9.1.2184
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/C:/Users/jpreisner/.m2/repository/org/sonarsource/scanner/maven/sonar-maven-plugin/3.9.1.2184/sonar-maven-plugin-3.9.1.2184.jar
[ERROR] urls[1] = file:/C:/Users/jpreisner/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.4/plexus-sec-dispatcher-1.4.jar
[ERROR] urls[2] = file:/C:/Users/jpreisner/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
[ERROR] urls[3] = file:/C:/Users/jpreisner/.m2/repository/org/codehaus/plexus/plexus-utils/3.2.1/plexus-utils-3.2.1.jar
[ERROR] urls[4] = file:/C:/Users/jpreisner/.m2/repository/org/sonarsource/scanner/api/sonar-scanner-api/2.16.2.588/sonar-scanner-api-2.16.2.588.jar
[ERROR] urls[5] = file:/C:/Users/jpreisner/.m2/repository/commons-lang/commons-lang/2.6/commons-lang-2.6.jar
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import  from realm ClassRealm[maven.api, parent: null]]
[ERROR]
[ERROR] -----------------------------------------------------
[ERROR] : org.sonar.java.model.ModifiersUtils
[ERROR] -> [Help 1]

[github-actions]

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

[dedece35]

Hi @jpreisner ,
thank you for your work but I must merge your work with some other PRs dealing with Java EC82 rule.
I created the new PR #89 for it.
Thus I close your PR, now.

This new rule is now available for the next release of the Java plugin.

Thank you a lot.

PS : all the PR dealing with EC82 rule which have been merged into the new above PR :

• [CHALLENGE24][Samarium] Implement rules EC82, EC205, EC1245 #58
• [Draft][EC82] Variable can be made constant #51
• Add Rule EC82: Make variable constant #50

PS2 : the java-project-test-project doesn't exist anymore because it was integrated into IT part in current java plugin.