Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing dots at the end of descriptions to stick to Sonar way. #52

Conversation

natixis-caen
Copy link
Contributor

Some of the rules descriptions have a trailing dot. All Sonar rules should not have one.
image

@natixis-caen natixis-caen force-pushed the remove-trailing-dots-in-descriptions branch 2 times, most recently from ef5b16e to f0f21e8 Compare August 27, 2024 14:40
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Dot seems to be avoided in SonarQube rules names indeed.
Can you update the CHANGELOG?

@natixis-caen natixis-caen force-pushed the remove-trailing-dots-in-descriptions branch from f0f21e8 to 2e3f43e Compare August 27, 2024 15:34
@natixis-caen
Copy link
Contributor Author

The CHANGELOG has been updated.

Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this change! LGTM 💯
I have updated the CHANGELOG file to move the line into the "Changes" section.

@utarwyn utarwyn merged commit 88f947e into green-code-initiative:main Aug 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants