[ISSUE 180] correction of SonarQube review for MarketPlace (sonar plu…

…gin)
green-code-initiative · Apr 18, 2023 · 43cf1da · 43cf1da
2 parents 08938f4 + 2caa752
commit 43cf1da
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 17 deletions.
diff --git a/java-plugin/pom.xml b/java-plugin/pom.xml
@@ -44,12 +44,6 @@
             <version>3.11</version>
         </dependency>
 
-        <dependency>
-            <groupId>com.google.guava</groupId>
-            <artifactId>guava</artifactId>
-            <version>31.0.1-jre</version>
-        </dependency>
-
         <!-- for security on regex patterns : https://github.com/google/re2j -->
         <dependency>
             <groupId>com.google.re2j</groupId>
@@ -89,10 +83,6 @@
                     <pluginClass>fr.greencodeinitiative.java.JavaPlugin</pluginClass>
                     <sonarLintSupported>true</sonarLintSupported>
                     <sonarQubeMinVersion>${sonarqube.version}</sonarQubeMinVersion>
-                    <!-- TODO : commented because plugin not loaded in SONAR if required version of java plugin is not installed -->
-                    <!-- TODO : check how to resolve it (how to force this version in SonarQube installation) -->
-                    <!-- <requirePlugins>java:${sonarjava.version}</requirePlugins> -->
-                    <basePlugin>java</basePlugin>
                     <jreMinVersion>${java.version}</jreMinVersion>
                 </configuration>
             </plugin>

diff --git a/javascript-plugin/pom.xml b/javascript-plugin/pom.xml
@@ -64,7 +64,6 @@
                     <pluginClass>fr.greencodeinitiative.javascript.JavaScriptPlugin</pluginClass>
                     <sonarLintSupported>true</sonarLintSupported>
                     <sonarQubeMinVersion>${sonarqube.version}</sonarQubeMinVersion>
-                    <basePlugin>javascript</basePlugin>
                     <jreMinVersion>${java.version}</jreMinVersion>
                 </configuration>
             </plugin>

diff --git a/php-plugin/pom.xml b/php-plugin/pom.xml
@@ -59,9 +59,7 @@
                     <pluginClass>fr.greencodeinitiative.php.PHPPlugin</pluginClass>
                     <sonarLintSupported>true</sonarLintSupported>
                     <sonarQubeMinVersion>${sonarqube.version}</sonarQubeMinVersion>
-                    <basePlugin>php</basePlugin>
                     <jreMinVersion>${java.version}</jreMinVersion>
-                    <requirePlugins>php:${sonarphp.version}</requirePlugins>
                     <sonarQubeMinVersion>${sonarqube.version}</sonarQubeMinVersion>
                     <jreMinVersion>${java.version}</jreMinVersion>
                 </configuration>

diff --git a/php-plugin/src/main/java/fr/greencodeinitiative/php/PhpRuleRepository.java b/php-plugin/src/main/java/fr/greencodeinitiative/php/PhpRuleRepository.java
@@ -24,12 +24,10 @@
 import java.io.InputStream;
 import java.net.URL;
 import java.nio.charset.StandardCharsets;
-import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
-import com.google.common.collect.ImmutableList;
 import fr.greencodeinitiative.php.checks.AvoidDoubleQuoteCheck;
 import fr.greencodeinitiative.php.checks.AvoidFullSQLRequestCheck;
 import fr.greencodeinitiative.php.checks.AvoidSQLRequestInLoopCheck;
@@ -90,7 +88,7 @@ public String repositoryKey() {
 
   @Override
   public List<Class<?>> checkClasses() {
-    return ImmutableList.of(
+    return List.of(
             AvoidDoubleQuoteCheck.class,
             AvoidFullSQLRequestCheck.class,
             AvoidSQLRequestInLoopCheck.class,

diff --git a/python-plugin/pom.xml b/python-plugin/pom.xml
@@ -57,7 +57,6 @@
                     <pluginName>${project.name}</pluginName>
                     <pluginClass>fr.greencodeinitiative.python.PythonPlugin</pluginClass>
                     <sonarLintSupported>true</sonarLintSupported>
-                    <requirePlugins>python:${sonarpython.version}</requirePlugins>
                     <sonarQubeMinVersion>${sonarqube.version}</sonarQubeMinVersion>
                     <jreMinVersion>${java.version}</jreMinVersion>
                 </configuration>