refactor: Replace hardcoded version number with a constant #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report😢 No conventional commits found. 👉 Learn more about the conventional commits usage at Greenbone. |
flyingbot91
force-pushed
the
use_variables_in_hardcoded_paths
branch
from
7730283
to
5494417
Compare
flyingbot91
changed the title
bjoernricks
suggested changes
Aug 14, 2023
flyingbot91
force-pushed
the
use_variables_in_hardcoded_paths
branch
2 times, most recently
from
fc28187
to
af31351
Compare
I gave pathlib a thought. However, since there are several path variables in the code containing a trailing slash (for instance in the unittests) and pathlib.Path() seems to ignore it I declined this option. See an example here: greenbone-feed-sync/tests/test_parser.py Line 811 in b509331 @bjoernricks For the moment, I decided to remove the path-like replacements and keep only the version variable replacement. |
bjoernricks
force-pushed
the
use_variables_in_hardcoded_paths
branch
from
af31351
to
0a2a447
Compare
bjoernricks
approved these changes
Jan 25, 2024
|
@flyingbot91 sorry I completely missed your answer and update here. Thanks a lot for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replace hardcoded version number with a constant.
Why
Prevent duplicated values in strings.
References
None.