Skip to content

Commit

Permalink
Fix: Correctly use test conditions in .docker/setup-mta.sh
Browse files Browse the repository at this point in the history
Added dollar signs to have the tests actually look at variable values and not
for the plain strings which leads to them being always true!
  • Loading branch information
moschlar committed Aug 26, 2024
1 parent c60c689 commit 38c8e9e
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions .docker/setup-mta.sh
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
#!/bin/bash

# Make any changes only when MTA_HOST has been set
if [ -n MTA_HOST ]; then
if [ -n "$MTA_HOST" ]; then
echo "setting up configuration file for mail agent"
CONFIG="/etc/msmtprc"
echo "host $MTA_HOST" > $CONFIG
[ -n MTA_PORT ] && echo "port $MTA_PORT" >> $CONFIG
[ -n MTA_TLS ] && echo "tls $MTA_TLS" >> $CONFIG
[ -n MTA_STARTTLS ] && echo "tls_starttls $MTA_STARTTLS" >> $CONFIG
[ -n MTA_TLS_CERTCHECK ] && echo "tls_certcheck $MTA_TLS_CERTCHECK" >> $CONFIG
[ -n MTA_AUTH ] && echo "auth $MTA_AUTH" >> $CONFIG
[ -n MTA_USER ] && echo "user $MTA_USER" >> $CONFIG
[ -n MTA_FROM ] && echo "from $MTA_FROM" >> $CONFIG
[ -n MTA_PASSWORD ] && echo "password $MTA_PASSWORD" >> $CONFIG
[ -n MTA_LOGFILE ] && echo "logfile $MTA_LOGFILE" >> $CONFIG
[ -n "$MTA_PORT" ] && echo "port $MTA_PORT" >> $CONFIG
[ -n "$MTA_TLS" ] && echo "tls $MTA_TLS" >> $CONFIG
[ -n "$MTA_STARTTLS" ] && echo "tls_starttls $MTA_STARTTLS" >> $CONFIG
[ -n "$MTA_TLS_CERTCHECK" ] && echo "tls_certcheck $MTA_TLS_CERTCHECK" >> $CONFIG
[ -n "$MTA_AUTH" ] && echo "auth $MTA_AUTH" >> $CONFIG
[ -n "$MTA_USER" ] && echo "user $MTA_USER" >> $CONFIG
[ -n "$MTA_FROM" ] && echo "from $MTA_FROM" >> $CONFIG
[ -n "$MTA_PASSWORD" ] && echo "password $MTA_PASSWORD" >> $CONFIG
[ -n "$MTA_LOGFILE" ] && echo "logfile $MTA_LOGFILE" >> $CONFIG
chown gvmd:mail $CONFIG
chmod 750 $CONFIG
fi

0 comments on commit 38c8e9e

Please sign in to comment.