Change: Lock table for each auto-deleted report individually #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The auto_delete_reports function no longer keeps the access exclusive lock on the reports table for the entire loop over the reports, but instead acquires and releases the lock for each report to delete. This gives other processes, like ones deleting reports manually, a better chance to acquire the lock on the reports table.
Conventional Commits Report
🚀 Conventional commits found. |
jhelmold
reviewed
Jul 21, 2023
jhelmold
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The auto_delete_reports function no longer keeps the access exclusive lock on the reports table for the entire loop over the reports, but instead acquires and releases the lock for each report to delete.
Why
This gives other processes, like ones deleting reports manually, a better chance to acquire the lock on the reports table.
References
GEA-2