Add: create_credential error case for type #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
timopollmeier
approved these changes
Oct 12, 2023
timopollmeier
force-pushed
the
create-cred-type
branch
from
1342bab
to
02b1a00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When create_credential fails to determine the type, return a specific error instead of just internal error.
Why
This caught me out when I was missing the type field, and a little more of a clue would have helped. (The command is too complex to just say that the type field is missing.)
Test with something like:
o m m "<create_credential><name>eg3</name><password>eg</password></create_credential>"... which should look like this:
o m m "<create_credential><name>eg3</name><password>eg</password><type>pw</type></create_credential>"