Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: GMP doc: add details attribute to GET_TARGETS #2170

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mattmundell
Copy link
Contributor

What

Add attribute details to GET_TARGETS in the GMP doc.

Why

Attribute was missing.

References

This attribute controls the presence of port_range (see handle_get_targets) and user_tags/tag (see send_get_common).

For example:

$ o m m '<get_targets filter="rows=10"/>'
<get_targets_response status="200" status_text="OK">
  <target id="0de4c2b4-987d-4a3b-9eba-fe92b3eaa8b2">

versus

$ o m m '<get_targets details="1" filter="rows=10"/>'
<get_targets_response status="200" status_text="OK">
  <target id="0de4c2b4-987d-4a3b-9eba-fe92b3eaa8b2">
    <port_range>T:1-3,5,7,...,49150</port_range>

@mattmundell mattmundell requested a review from a team as a code owner April 15, 2024 23:00
Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

@bjoernricks bjoernricks merged commit 9660bba into main Apr 16, 2024
9 checks passed
@bjoernricks bjoernricks deleted the gmp-doc-get-targets branch April 16, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants