Fix: added PostgreSQL 16 to the list of known versions in FindPostgre… #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
mattmundell
reviewed
Apr 26, 2024
bjoernricks
approved these changes
May 2, 2024
…SQL.cmake The gvm compiles only when used with PostgreSQL (Debian 16.2-1). The older version of PSQL (PSQL 15) isn't in Kali's rolling repo anymore.
Co-authored-by: Matt Mundell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…SQL.cmake
The gvm compiles only when used with PostgreSQL (Debian 16.2-1). The older version of PSQL (PSQL 15) isn't in Kali's rolling repo anymore.
What
This fixes cmake when compiling from source on Kali 2024.1, as the older version of PSQL no longer present in the APT's repository. Without it, cmake isn't able to find the PSQL-16. After the change was made, I was able to compile gvmd.
Why
PSQL-16 was released at 2023-09-14, and its only a matter of time untill it will become default version on LTS builds also.
You also can't use the apt-package version of the greenborne on kali, as it's broken, so compiling seems to be the only way.
The fix doesn't seem to break the build process*, so I'd say suggest bumping the version.
Tests
The only thing to consider, is that I was following the guide, that seems to download source of an older version - 23.2.0