Filter duplicate results and host details #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all duplicate results from the scanner were filtered since OSP results are fetched while the scan is running and duplicates can exist in the same batch of fetched results.
Conventional Commits Report
🚀 Conventional commits found. |
timopollmeier
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use a hash map to lookup hashed results and host details in order to filter duplicates that may exist in the same batch of results fetched from the scanner.
Why
Not all duplicate results from the scanner were filtered since OSP results are fetched while the scan is running and duplicates
can exist in the same batch of fetched results even before insertion in the database.
References
GEA-525
Tested in local development environment by modifying ospd-openvas to duplicate every result and checking that duplicated results are filtered out after the fix.