Add: functions to handle an Openvasd scan task #2262
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
|
Depends on greenbone/gvm-libs#826 |
jjnicola
force-pushed
the
openvasd-integration
branch
from
3fe6dfa
to
ed0b115
Compare
|
Depends on #2169 |
jjnicola
force-pushed
the
openvasd-integration
branch
2 times, most recently
from
a19d368
to
d5d1f2a
Compare
jjnicola
force-pushed
the
openvasd-integration
branch
2 times, most recently
from
8dc76c1
to
1d64df0
Compare
jjnicola
force-pushed
the
openvasd-integration
branch
from
1d64df0
to
ff7a256
Compare
jjnicola
force-pushed
the
openvasd-integration
branch
from
ff7a256
to
0e31fee
Compare
mattmundell
reviewed
Oct 15, 2024
| @@ -2571,8 +3166,27 @@ manage_sync_nvts (int (*fork_update_nvt_cache) (pid_t*)) | |||
| int | |||
| update_or_rebuild_nvts (int update) | |||
| { | |||
| gchar *db_feed_version, *scanner_feed_version; | |||
There was a problem hiding this comment.
Suggested change
| gchar *db_feed_version, *scanner_feed_version; | |
| gchar *db_feed_version, *scanner_feed_version; |
mattmundell
reviewed
Oct 15, 2024
| @@ -20074,14 +20079,17 @@ nvt_severity (const char *nvt_id, const char *type) | |||
| { | |||
| char *severity = NULL; | |||
|
|
|||
| if (strcasecmp (type, "Alarm") == 0 && nvt_id) | |||
| if ((strcasecmp (type, "alarm") == 0 || strcasecmp (type, "Alarm") == 0) && nvt_id) | |||
There was a problem hiding this comment.
Just browsing through and this looks weird, because strcasecmp ignores case.
jjnicola
force-pushed
the
openvasd-integration
branch
from
2d1bbea
to
9343d96
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add: functions to handle an Openvasd scan task
SC-1056
SC-1053
SC-1058
SC-1057
SC-1060
Why
Required for handling scans via openvasd
References
Checklist