Logrotate fix #2263
Closed
Logrotate fix #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue in .deb credential script that throws an error when running script twice for a username to replace a credential
Fixing issues with tar by correcting paths required to create the data archive before compiling the .deb
Fixing a bug in the EXE credential creator resulting from syntax error in the ExecWait commands.
Setting "_topdir" in the rpmbuild config is required to prevent the rpmbuild process from attempting to access the gvm user's home directory, (which does not exist) resulting in a 0-byte user credential creator .rpm package.
Conventional Commits Report😢 No conventional commits found. 👉 Learn more about the conventional commits usage at Greenbone. |
|
Seems there is a similar PR already open since quite some time: #2051 |
|
Moved to a single commit in /pull/2269. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This will add proper permissions to the logrotate configuration file, which is placed into the
/etc/logrotate.d/gvmdduring the make build process.Why
It was pointed out from this forum post that the logs do not have the correct permission configuration for logrotate.
References
Forum post with discussion
Checklist