Add: Implement create and list endpoint #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoetzegb
force-pushed
the
implement-service
branch
from
f69dcbe
to
66d00e0
Compare
mgoetzegb
changed the title
mgoetzegb
force-pushed
the
implement-service
branch
from
66d00e0
to
4c1a79f
Compare
Conventional Commits Report
🚀 Conventional commits found. |
endyApina
reviewed
May 13, 2024
mgoetzegb
force-pushed
the
implement-service
branch
from
4c1a79f
to
77a7dd0
Compare
- wrong column name for origin uri, should be snake case - timestamp is mandatory
ultimately those components should be extracted to the opensight-golang-libraries
mgoetzegb
force-pushed
the
implement-service
branch
from
77a7dd0
to
7ae85d4
Compare
endyApina
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implement create and list notifications endpoint. Created notifications are stored in the database and can be retrieved later via list.
Filtering and Sorting is not yet supported.
Note: The packages
errsandrestErrorHandleras well as the functionPrepareResultSelectorwas duplicated from the VI backend repo. Ultimately this code should be moved to greenbone/opensight-golang-libraries.Why
The service is supposed to do something.
References
VTI-151
Checklist