Make missing_non_null_constraint skip contextual validators (#189)

gregnavis · Dec 12, 2024 · b0d597f · b0d597f
1 parent c662c8f
commit b0d597f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/active_record_doctor/detectors/missing_non_null_constraint.rb b/lib/active_record_doctor/detectors/missing_non_null_constraint.rb
@@ -67,6 +67,7 @@ def required_presence_validators(model)
         model.validators.select do |validator|
           validator.is_a?(ActiveRecord::Validations::PresenceValidator) &&
             !validator.options[:allow_nil] &&
+            validator.options[:on].blank? &&
             (rails_belongs_to_presence_validator?(validator) || !conditional_validator?(validator))
         end
       end

diff --git a/test/active_record_doctor/detectors/missing_non_null_constraint_test.rb b/test/active_record_doctor/detectors/missing_non_null_constraint_test.rb
@@ -137,6 +137,16 @@ def test_validators_allowing_nil_on_optional_columns_are_allowed
     refute_problems
   end
 
+  def test_validators_with_specific_context_on_optional_columns_are_allowed
+    Context.create_table(:users) do |t|
+      t.string :name, null: true
+    end.define_model do
+      validates :name, presence: true, on: :create
+    end
+
+    refute_problems
+  end
+
   def test_models_with_non_existent_tables_are_skipped
     Context.define_model(:User)