Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing_unique_indexes detector's ignore_columns config for has_one associations #153

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fix missing_unique_indexes detector's ignore_columns config for has_one associations #153

merged 1 commit into from
Dec 4, 2023

Conversation

fatkodima
Copy link
Contributor

Fixes #152.

@fatkodima fatkodima mentioned this pull request Nov 6, 2023
Closed
beetlegius-jt
beetlegius-jt approved these changes Nov 7, 2023
View reviewed changes
Copy link

@beetlegius-jt beetlegius-jt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gregnavis gregnavis merged commit b013fc0 into gregnavis:master Dec 4, 2023
61 checks passed
@fatkodima fatkodima deleted the fix-missing_unique_indexes-has_one-ignore_columns branch December 4, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raivil raivil raivil approved these changes

@beetlegius-jt beetlegius-jt beetlegius-jt approved these changes

@gregnavis gregnavis gregnavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to ignore missing_unique_indexes for has_one
4 participants
@fatkodima @gregnavis @beetlegius-jt @raivil