Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing_non_null_constraint: ignore database views #201

Merged
merged 1 commit into from
Jan 11, 2025
Merged

missing_non_null_constraint: ignore database views #201

merged 1 commit into from
Jan 11, 2025

Conversation

fatkodima
Copy link
Contributor

Fixes #200.

@fatkodima
Copy link
Contributor Author

@gregnavis Can you do another round of merges or make me a maintainer of this repository?

@gregnavis gregnavis added the false positive Pull requests that fix false positives label Jan 3, 2025
@gregnavis
Copy link
Owner

@fatkodima, I'll do some merging soon. Sorry, I've been dealing with some personal stuff.

@gregnavis gregnavis added this to the 2.0 milestone Jan 4, 2025
gregnavis
gregnavis requested changes Jan 11, 2025
View reviewed changes
Copy link
Owner

@gregnavis gregnavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some comments on the test case.

test/active_record_doctor/detectors/missing_non_null_constraint_test.rb Outdated Show resolved Hide resolved
test/active_record_doctor/detectors/missing_non_null_constraint_test.rb Outdated Show resolved Hide resolved
test/active_record_doctor/detectors/missing_non_null_constraint_test.rb Outdated Show resolved Hide resolved
test/active_record_doctor/detectors/missing_non_null_constraint_test.rb Outdated Show resolved Hide resolved
@gregnavis gregnavis added the waiting Waiting for updates from contributors label Jan 11, 2025
@fatkodima fatkodima force-pushed the missing_non_null_constraint-ignore-views branch from 0070422 to ccb8754 Compare January 11, 2025 13:47
@fatkodima
Copy link
Contributor Author

Made changes.

@gregnavis
Copy link
Owner

@fatkodima, your nickname should be "lightning" 😄 Thanks for the update. Let's see whether the CI is happy with the new version of transient_record.

@gregnavis gregnavis merged commit 70bf5ad into gregnavis:master Jan 11, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregnavis gregnavis gregnavis approved these changes

Assignees
No one assigned
Labels
false positive Pull requests that fix false positives waiting Waiting for updates from contributors
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

False positives on missing_non_null_constraint for view-backed models
2 participants
@fatkodima @gregnavis