Upgrade Jetty 9.4 to support Log4J2 >= 2.9 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javabrett
requested changes
Mar 3, 2018
| @@ -14,7 +14,7 @@ jetty8_version=8.1.8.v20121106 | |||
| jetty8_servlet_api_version=3.0.1 | |||
| jetty9_version=9.2.22.v20170606 | |||
| jetty93_version=9.3.20.v20170531 | |||
| jetty94_version=9.4.6.v20170531 | |||
| jetty94_version=9.4.7.v20170914 | |||
There was a problem hiding this comment.
I've been using jetty94Version=9.4.8.v20171121 in a local project for a couple of weeks, and it seems to be working OK. Was released Nov 2017. Would you mind testing that and if OK updating the PR?
There was a problem hiding this comment.
I notice that this is based of someone else's branch that you probably won't have access-to. To save messing with another PR I'll just merge this then bump the version up again.
javabrett
approved these changes
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of akhikhl#406