-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make seed independent of num.threads and add legacy option #1447
Conversation
Just so a user doesnt crash R by typing options(grf.legacy.seed = "kangaroo")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great we're finally fixing this. I do wonder if the grf.legacy.seed
option adds more complexity than it's worth ... it's pretty easy to install old versions of R packages, and for reproducibility it's good practice to save and fix the package version. And now, we'll have to figure out when it's save to deprecate and remove the new option grf.legacy.seed
!
Yes it adds complexity, but that's the price we have to pay in order to do this imo! Past versions of GRF are not available as CRAN binaries and have to be installed from source, which unfortunately can be challenging for many users. (there's a bunch of unrelated commits below because I got a new arm mac that evidently produces slightly different results for characterization tests stored on the repo using x86-based systems) |
This reverts commit 49d2270.
This PR makes the random
seed
argument produce the same results irrespective of whatnum.threads
is set to. In order to reproduce past results, a global package optionoptions(grf.legacy.seed)
is added which can be set toTRUE
to revert back to the old behavior whereseed
andnum.threads
interacts (see grf_options for an example).#1368.