Revert "generate input/output bindings to the GridJS package" #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@salamaashoush anything I can help with? |
|
There are some type-checking issues with the way we generate bindings now, I am preparing another PR to improve CI and use the hardcoded input/output for now |
|
@joeskeen I had to revert the generated bindings for now, since gridjs types are not the best and we got some ts type issues in the build, also signals needs a bit of refactoring so I also didn't include it, maybe we could use https://angular.io/guide/signal-inputs instead of manually updating it using effect, for now to publish a working and tested version I used the old implementation, thanks a lot for contributing the scripts, I will keep them until we figure a more reliable way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #182