Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize how the infinite norm is computed in non-linear solvers #940

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

JordiManyer
Copy link
Member

@JordiManyer JordiManyer commented Aug 30, 2023

Algebra._check_convergence was using a self-implemented version of the infinite norm. This only worked for serial vectors. I've generalized the approach to use the Base.maximum(abs,v) method, which should be valid (and optimized) for each possible implementation of AbstractVector. Notably, this now works for PVector.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Merging #940 (6f7d8e3) into master (578f5b7) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
- Coverage   88.43%   88.42%   -0.01%     
==========================================
  Files         174      174              
  Lines       20627    20621       -6     
==========================================
- Hits        18241    18235       -6     
  Misses       2386     2386              
Files Changed Coverage Δ
src/Adaptivity/AdaptedTriangulations.jl 77.36% <100.00%> (ø)
src/Algebra/NLSolvers.jl 98.85% <100.00%> (-0.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JordiManyer JordiManyer merged commit 0b5dca3 into master Aug 30, 2023
7 checks passed
@JordiManyer JordiManyer deleted the change-inf-norm branch August 30, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants