Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved allocate_in_range/domain #960

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Improved allocate_in_range/domain #960

merged 2 commits into from
Dec 4, 2023

Conversation

JordiManyer
Copy link
Member

@JordiManyer JordiManyer commented Dec 3, 2023

Improved the methods allocate_in_range and allocate_in_domain:

  • The matrix methods now use axes(A,d). This is more general, and will allow us to re-use these methods for distributed matrices.
  • Added new methods that create a 'default' vector type given the input matrix type.
  • Added support for BlockArrays, which are used in MultiField.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (4a76c17) 88.14% compared to head (034600a) 88.08%.
Report is 3 commits behind head on master.

Files Patch % Lines
src/Algebra/AlgebraInterfaces.jl 27.77% 13 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #960      +/-   ##
==========================================
- Coverage   88.14%   88.08%   -0.06%     
==========================================
  Files         177      177              
  Lines       21064    21077      +13     
==========================================
  Hits        18566    18566              
- Misses       2498     2511      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordiManyer JordiManyer merged commit 0f3b981 into master Dec 4, 2023
7 checks passed
@JordiManyer JordiManyer deleted the allocate-vectors branch December 4, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants