Bugfix: TransientFESpaces broken for Gridap#master #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #135 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 12 12
Lines 2448 2458 +10
======================================
- Misses 2448 2458 +10 ☔ View full report in Codecov by Sentry. |
oriolcg
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
StokesOpenBoundaryTests.jlbreaks on Gridap#master.After investigating a little, this seems to come from this recent PR, where we added block assembly to
TransientMultiFieldFESpaces. In doing so, we made the type quite a lot more complex. This requires moreFESpaceAPI methods to be implemented byDistributedFESpace.I think all tests are good now.
@amartinhuertas @oriolcg @tamaratambyah