Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chart for limits set to vizualise limits distribution #2589

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

basseche
Copy link
Contributor

No description provided.

github-actions[bot]

This comment was marked as outdated.

@basseche basseche force-pushed the graphique_LimitSets branch from a644124 to 79113c7 Compare February 17, 2025 09:41
@gridsuite gridsuite deleted a comment from github-actions bot Feb 17, 2025
@basseche basseche self-assigned this Feb 17, 2025
@gridsuite gridsuite deleted a comment from sonarqubecloud bot Feb 17, 2025
@basseche basseche requested a review from thangqp February 18, 2025 13:35
@basseche basseche changed the title WIP : graph limitset Add Chart for limits set to vizualise limits distribution Feb 18, 2025
Mathieu-Deharbe

This comment was marked as off-topic.

@Mathieu-Deharbe Mathieu-Deharbe self-requested a review February 18, 2025 16:14
Mathieu-Deharbe

This comment was marked as resolved.

Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the skills to analyse the changes you made in the dependencies but many things are updated. @etiennehomer is that ok ?


What you did is not exactly what is in the specs especially :

  1. you are supposed to display the tempo but only display the limit name :
    image

-> for the same reason this is not respected :
image

  1. "Si des valeurs sont incohérentes, on affichera en rouge le nom et la valeur de la limite." => I don't see how it happens and what it means but I know that I can have limit with a value inferior to the IST value and no error displayed.
    image

@Mathieu-Deharbe Mathieu-Deharbe self-requested a review February 19, 2025 16:15
@etiennehomer
Copy link
Contributor

I don't have the skills to analyse the changes you made in the dependencies but many things are updated. @etiennehomer is that ok ?

Yes it's ok. The changes come from the transitive dependances (https://www.npmjs.com/package/@mui/x-charts?activeTab=dependencies) and the package-lock.json is not changed after I did npm install again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants