hotfix for tag-overflow's matchingText embolden feature regression #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You must specify one of the following labels: bugfix, housekeeping, new-feature, enhancement, ignore-for-release, dependencies in order for this PR to appear in the release notes. |
jmcmichael
added
the
bugfix
|
As far as I can tell, this seems to have resolved itself. I think we can close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tag-overflow components' filter text embolden feature is working for me now, however I'm not quite sure why. I'm checking this in so y'all can see if this fixes the issue for you. I traced the filter text and logic, adding variable debug output in child templates, and at some point the proper tags were showing up emboldened again. After I reverted the templates to remove the debug output, and reverted any other updates I made to components to figure out which modification fixed the issue, tags matching col filter text were still being emboldened.
I did keep an update that makes the 'matching-tag' ngClass expression case-insensitive, which could cause confusing results if users are expecting 'C' to match all 'c' in tag labels. That's the entirety of the PR. If I revert this change locally, the filter embolden feature still works... so, not sure what's going on.
Fixes #971