Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new valid_algorithms command (#1106) #1108

Merged
merged 11 commits into from
Jun 5, 2024

Conversation

ldhtnp
Copy link
Contributor

@ldhtnp ldhtnp commented Jun 4, 2024

Completed issue#1106 and all tests are passing on my end

@ldhtnp ldhtnp changed the title Issues/1106 Added new valid_algorithms command (#1106) Jun 4, 2024
Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. I made a few minor change suggestion.

docs/pvacbind/additional_commands.rst Outdated Show resolved Hide resolved
docs/pvacfuse/additional_commands.rst Outdated Show resolved Hide resolved
docs/pvacseq/additional_commands.rst Outdated Show resolved Hide resolved
docs/pvacvector/additional_commands.rst Outdated Show resolved Hide resolved
pvactools/lib/valid_algorithms.py Outdated Show resolved Hide resolved
pvactools/lib/valid_algorithms.py Outdated Show resolved Hide resolved
pvactools/lib/valid_algorithms.py Outdated Show resolved Hide resolved
Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@susannasiebert susannasiebert merged commit 7bc69d1 into griffithlab:staging Jun 5, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants