-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added argument for specifying NetMHCIIpan/NetMHCIIpanEL version #1181
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good overall. I made a few comments for suggested changes.
Also, you'll want to add tests for your new command in the |
try: | ||
return {'score': float(line['score'])} | ||
except: | ||
return {'ic50': float(line['ic50'])} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block of code concerns me. NetMHCIIpan_el is elution algorithm and as such doesn't return an ic50. Is there a specific version combo that returns this header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Digging into this some more, it looks like standalone IEDB returns the headers as "ic50" instead of score under NetMHCpan_EL version 4.2 and 4.3. This works but I think it would be better if we could specify a set of rules to pick one over the other instead of using a try and except. This would require us to adapt this module to track whether or not IEDB was used standalone.
I added the argument
--netmhc_pan_version
to pvacseq, pvacbind, pvacfuse, pvacsplice, and pvacvector. The argument supports four versions: 4.0, 4.1, 4.2, and 4.3. I also added an argument that can be used to list the valid versionsvalid_netmhcpan_versions
. Alongside the additions I had to make to get the arguments implemented, I had to modify the code used to remove the sample name and grab the method name inoutput_parser.py
because the method name can now include a version number. Before this modification, the version number would be trimmed and dropped off of the method name resulting in issues downstream.This is for issue #457