Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include non-human transcripts to pvacsplice #1198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mhoang22
Copy link
Contributor

@mhoang22 mhoang22 commented Feb 7, 2025

previously combine_input.py searched for transcript_id starts with 'ENST' in the annotated_vcf(tsv). this would exclude non-human transcripts.
we change the code so that it searches for transcript_id contains ENS*T instead, to include non-human transcripts.

Notes on ensembl transcript name:
https://useast.ensembl.org/info/genome/stable_ids/prefixes.html
https://useast.ensembl.org/Help/Faq?id=488

(example: mice: ENSMUST, dog: ENSCAFT, cat: ENSFCAT)

Copy link
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this looks good but I wonder if we should add some non-human tests here to cover this specific case. In tests/test_pvacsplice_combine_outputs.py you can basically replicate/copy the test_combine_inputs_runs_and_produces_expected_output test and use your dog test files if we're ok with putting them publicly on GitHub. You'll need to use intermediate files produced by pVACsplice for the junctions and variant file inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants