FIX: UX Document Conversion in multi worker environment #1378
+512
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflorent
reviewed
Jan 14, 2025
app/client/ui/DocumentSettings.ts
Outdated
Comment on lines
475
to
488
| const typeList: DocumentTypeItem[] = [{ | ||
| label: t('Regular'), | ||
| type: '' | ||
| }, { | ||
| label: t('Template'), | ||
| type: 'template' | ||
| }, { | ||
| label: t('Tutorial'), | ||
| type: 'tutorial' | ||
| }].map((el) => ({ | ||
| ...el, | ||
| value: el.label, | ||
| cleanText: el.label.trim().toLowerCase() | ||
| })); |
There was a problem hiding this comment.
Calling t top-level like this can be problematic. I'd suggest wrapping this in a function that returns the array.
There was a problem hiding this comment.
Hello @georgegevoian,
For my own culture can you be more explicit on what can be problematic with using t() at top level?
There was a problem hiding this comment.
I think that's because the t function may not be initialized correctly (it needs to download a JSON file with the locales).
Co-authored-by: hexaltation <[email protected]> Co-authored-by: fflorent <[email protected]>
todo: tests, notification of success
fix: url deduction for page reload to apply new document type
TODO onboarding popup TODO better waiting for url change
remove uneeded async and better function naming
fix: various nitpicks
Co-authored-by: fflorent <[email protected]>
hexaltation
force-pushed
the
issue-1015-convert-document-to-template-tuto
branch
from
b3e151f to
e4756cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#1181 was revert due to gristlabs internal CI failing in multi-worker environment.
Proposed solution
This PR implements the same user journey fixing inconsistencies with multi-worker.
We will discuss @georgegevoian's remark #1015 (comment) in an other issue if changes are needed in a product point of view.
Related issues
Fixes #1015
Has this been tested?