Avoid using oidc callback URL as post-login URL #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Florent <[email protected]>
jonathanperret
force-pushed
the
fix-oidc-callback-loop
branch
from
33a0221 to
34f12a4
Compare
paulfitz
reviewed
Jan 16, 2025
| @@ -97,14 +97,15 @@ export function getWelcomeHomeUrl() { | |||
| return _buildUrl('welcome/home').href; | |||
| } | |||
|
|
|||
| const FINAL_PATHS = ['/signed-out', '/account-deleted']; | |||
| const PATHS_TO_EXCLUDE_FROM_NEXT = ['/signed-out', '/account-deleted', '/oauth2/callback']; | |||
There was a problem hiding this comment.
Putting OIDC-specific logic in the front-end makes me feel a little itchy. Is there any way to quarantine the OIDC behavior to https://OIDCConfig.ts? Via a change to the CALLBACK_URL handler there perhaps?
There was a problem hiding this comment.
That's a very good point. I'll try to see if there's a way to delegate this to login middleware such as OIDC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #1383.
Proposed solution
This PR fixes the referenced issue by adding the OIDC callback route to the list of routes that should not be redirected to after sign-in.
We also changed the names of the related constant and function to make their role hopefully clearer.
Has this been tested?
Screenshots / Screencasts
grist-oidc-stuck-on-sign-in-fixed.mp4