specify NODE_ENV=production by default in docker image #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The express web framework that Grist uses is sensitive to a NODE_ENV environent variable. Grist also gives some operations more time when this variable is set. At Grist Labs we have this flag set for our SaaS, but until now it hasn't been set in the regular docker image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The express web framework that Grist uses is sensitive to a
NODE_ENVenvironment variable. Grist also gives some operations more time when this variable is set. At Grist Labs we have this flag set for our SaaS, but until now it hasn't been set in the regular docker image.Has this been tested?
This setting is used in the Grist Labs SaaS at https://docs.getgrist.com