Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error message on documents for non-owner users #790

Merged

Conversation

fflorent
Copy link
Collaborator

The error can often be fixed by just reloading the document with no need to worry the document owners

For example, when the error message is: "interrupted by reconnect"

Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a reasonable change, some small comments.

app/client/models/DocPageModel.ts Outdated Show resolved Hide resolved
The error can often be fixed by just reloading the document with no need
to worry the document owners

For example, when the error message is: "interrupted by reconnect"
@fflorent fflorent force-pushed the change-recover-error-message branch from 30d03ec to b6fefd8 Compare December 19, 2023 14:24
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fflorent ! Sorry for delay.

@paulfitz paulfitz merged commit 97df12c into gristlabs:main Jan 3, 2024
13 checks passed
@fflorent fflorent deleted the change-recover-error-message branch January 4, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants