Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: ACL rules has no max-width #820

Merged

Conversation

CamilleLegeron
Copy link
Collaborator

@CamilleLegeron CamilleLegeron commented Jan 8, 2024

#674

There were a glitch on the ACL formula Editor, so add style to hide this glitch.
Screenshot from 2024-01-09 11-59-40

@CamilleLegeron CamilleLegeron marked this pull request as ready for review January 9, 2024 11:11
ACLRules : set max width larger

style: revert commit 'style: ACL rules has no max-width'

style: hide the border inside ACLFormulaEditor

cancel formatting file
@georgegevoian
Copy link
Contributor

#674

There were a glitch on the ACL formula Editor, so add style to hide this glitch. Screenshot from 2024-01-09 11-59-40

That looks like the indicator line that's usually shown at 80 columns. It should also be visible in the regular Grist formula editor. @anaisconce, do we want to hide that line?

Copy link
Contributor

@georgegevoian georgegevoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CamilleLegeron.

Just one suggestion.

app/client/aclui/ACLFormulaEditor.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@georgegevoian georgegevoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CamilleLegeron!

@georgegevoian georgegevoian merged commit af38519 into gristlabs:main Feb 15, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants