Make free coaching call url configurable and popup translatable #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamilleLegeron
changed the title
app/client/ui/WelcomeCoachingCall.ts
Outdated
| dom.on('click', () => { | ||
| dismissPopup(false); | ||
| logTelemetryEvent('clickedScheduleCoachingCall'); | ||
| }), | ||
| { | ||
| href: FREE_COACHING_CALL_URL, | ||
| href: getFreeCoachingCallUrl(), |
There was a problem hiding this comment.
Suggested change
| href: getFreeCoachingCallUrl(), | |
| href: getGristConfig().freeCoachingCallUrl, |
This way, you don't need getFreeCoachingCallUrl in gristUrls.ts.
| @@ -54,6 +54,7 @@ export function makeGristConfig(options: MakeGristConfigOptions): GristLoadConfi | |||
| baseDomain, | |||
| singleOrg: process.env.GRIST_SINGLE_ORG, | |||
| helpCenterUrl: process.env.GRIST_HELP_CENTER || "https://support.getgrist.com", | |||
| freeCoachingCallUrl: process.env.FREE_COACHING_CALL_URL || "https://calendly.com/grist-team/grist-free-coaching-call", | |||
There was a problem hiding this comment.
Could you add FREE_COACHING_CALL_URL to the list in the README? Thanks.
|
Thanks @georgegevoian for the review. I made the modifications |
Co-authored-by: George Gevoian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
One user of our ANCT instance used the coaching call url that give a calendly link of gristlabs. So, we wanted to make it configurable by instance with the gristlabs calendly by default.