Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks, improvements, and hacks to puter.com, and implementation of a puter integration #39

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

dsagal
Copy link
Member

@dsagal dsagal commented Jan 26, 2025

grist-static changes:

  • Pass Python errors back through pyCall
  • Support importing Excel files by supporting binary data and choosing the right parser.
  • Various hooks to allow overriding or extending grist-static behavior.
  • Hack to add a "save" hook for when "Save document" button is clicked.

puter.com integration, via page/index_puter.html:

  • Support opening and saving .grist files.
  • Support opening all file types supported for imports (csv, xlsx, etc)
  • Support saving csv files back to the original location, with a warning.
  • Show logged-in Puter user (not important, but we don't have UI to avoid showing any user)
  • Show when the file is saved/unsaved, and prompt to save when needed.

@dsagal dsagal requested a review from paulfitz January 26, 2025 22:11
@dsagal
Copy link
Member Author

dsagal commented Jan 26, 2025

There are no tests... I manually tested some flows in Puter, but there is a high risk this breaks something with other uses of grist-static, like the csv viewer. Might be safer to release to a separate URL for the sake of Puter, and leave a proper update of grist-static for when someone has time to poke at grist-static a bit more?

@dsagal
Copy link
Member Author

dsagal commented Jan 26, 2025

I released for now into s3://grist-static/experiments/ePUTER01/, with the entrypoint at index_puter2.html (the "2" suffix because i couldn't get past caching of a bad version). That's enough to get the Puter grist app working, so I'll actually update it to that (vs the current pointer to Grist SaaS on prod), but happy to update if/when it's available in a more permanent place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant