editor: Fixing bug that caused infinite loop during preview #145
+90
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an inner widget was reporting some mandatory columns to map, the builder was causing infinite loop. More in comment, but here is summary.
Here the basic idea was not to call the
configure
endpoint from the builder, instead builder is injecting its configuration in theconfigure
call from the inner widget, that way Grist sees only one configure call, and columns mapping stays consistent during reloads.Not related:
Here is a document with this builder and markdown widget's content inside (with mandatory column):
https://public.getgrist.com/d1t1x4BvxuMK/JsFiddle