Skip to content

Commit

Permalink
Remove upper boundary on ActiveRecord, test main
Browse files Browse the repository at this point in the history
In order to keep this gem up to date with Rails main we'd like to start
testing against it on a schedule. Right now this will test against Rails
main daily. Once we confirm this gem is compatible with the current
Rails main we'll set it up to notify us if the main testing workflow
fails 3 days in a row so we can go and fix it. We decided on 3 days in a
row and not on _every_ failure just in case it only fails for some flaky reason.

I added `/gemfiles/activerecord_main.gemfile.lock` to `.gitignore`
because, for obvious reasons, we never want to lock the sha we're using.
  • Loading branch information
HeyNonster committed Jun 10, 2024
1 parent 7c0580c commit 862d2c8
Show file tree
Hide file tree
Showing 10 changed files with 47 additions and 13 deletions.
27 changes: 27 additions & 0 deletions .github/workflows/active_record_main_specs.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: CI
on:
schedule:
- cron: "0 0 * * *" # Run every day at 00:00 UTC
workflow_dispatch:
push:
branches: [master]
pull_request:
branches: [master]
jobs:
build:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
ruby: ['3.1', '3.2', '3.3']
activerecord: ['main']
name: ruby${{ matrix.ruby }} activerecord_${{ matrix.activerecord }}
env:
BUNDLE_GEMFILE: gemfiles/activerecord_${{ matrix.activerecord }}.gemfile
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- run: bundle exec rspec
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
test_db.sqlite
.ruby-version
/gemfiles/activerecord_main.gemfile.lock
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: .
specs:
active_record-comments (0.8.0)
activerecord (>= 5, < 7.2)
activerecord (>= 5)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -58,4 +58,4 @@ DEPENDENCIES
sqlite3 (~> 1.3, >= 1.3.6)

BUNDLED WITH
2.3.12
2.4.22
2 changes: 1 addition & 1 deletion active_record-comments.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ Gem::Specification.new do |s|
s.homepage = "https://github.com/grosser/active_record-comments"
s.files = `git ls-files lib/ MIT-LICENSE`.split("\n")
s.license = "MIT"
s.add_runtime_dependency "activerecord", ">= 5", "< 7.2"
s.add_runtime_dependency "activerecord", ">= 5"
s.required_ruby_version = '>= 2.7'
end
4 changes: 2 additions & 2 deletions gemfiles/activerecord_5.2.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: ..
specs:
active_record-comments (0.8.0)
activerecord (>= 5, < 7.2)
activerecord (>= 5)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -58,4 +58,4 @@ DEPENDENCIES
sqlite3 (~> 1.3, >= 1.3.6)

BUNDLED WITH
2.3.12
2.4.22
4 changes: 2 additions & 2 deletions gemfiles/activerecord_6.0.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: ..
specs:
active_record-comments (0.8.0)
activerecord (>= 5, < 7.2)
activerecord (>= 5)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -58,4 +58,4 @@ DEPENDENCIES
sqlite3 (~> 1.4)

BUNDLED WITH
2.3.12
2.4.22
4 changes: 2 additions & 2 deletions gemfiles/activerecord_6.1.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: ..
specs:
active_record-comments (0.8.0)
activerecord (>= 5, < 7.2)
activerecord (>= 5)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -57,4 +57,4 @@ DEPENDENCIES
sqlite3 (~> 1.4)

BUNDLED WITH
2.3.12
2.4.22
4 changes: 2 additions & 2 deletions gemfiles/activerecord_7.0.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: ..
specs:
active_record-comments (0.8.0)
activerecord (>= 5, < 7.2)
activerecord (>= 5)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -55,4 +55,4 @@ DEPENDENCIES
sqlite3 (~> 1.4)

BUNDLED WITH
2.3.12
2.4.22
4 changes: 2 additions & 2 deletions gemfiles/activerecord_7.1.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: ..
specs:
active_record-comments (0.8.0)
activerecord (>= 5, < 7.2)
activerecord (>= 5)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -79,4 +79,4 @@ DEPENDENCIES
sqlite3 (~> 1.4)

BUNDLED WITH
2.4.21
2.4.22
6 changes: 6 additions & 0 deletions gemfiles/activerecord_main.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
eval_gemfile "common.rb"

gem "activerecord", github: "rails/rails", branch: "main"
gem "sqlite3", "~> 1.4"

gem 'pry-byebug'

0 comments on commit 862d2c8

Please sign in to comment.