Skip to content

Commit

Permalink
Reverted buildx image back to binfmt (#138)
Browse files Browse the repository at this point in the history
This PR reverts the `buildx` base image back to using `binfmt` because
`binfmt` supports building both ARM and x86 images directly and does not
require additional binaries like `alpine` does.

Note that `binfmt` does NOT support building images from ARM machines
(e.g. Apple Silicon or RPis), so the build script will need to be ran on
x86 machines (e.g. AWS EC2).
  • Loading branch information
honeytung authored Nov 20, 2024
1 parent 8a0b7da commit 8265846
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deploy/bin/build-push-edge-endpoint-image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ fi
# https://docs.docker.com/engine/install/ubuntu/

# Install QEMU, a generic and open-source machine emulator and virtualizer
docker run --rm --privileged linuxkit/alpine:146f540f25cd92ec8ff0c5b0c98342a9a95e479e
docker run --rm --privileged linuxkit/binfmt:af88a591f9cc896a52ce596b9cf7ca26a061ef97

# Check if tempbuilder already exists
if ! docker buildx ls | grep -q tempgroundlightedgebuilder; then
Expand Down

0 comments on commit 8265846

Please sign in to comment.