-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CICD: Runs a full GPU install on an EC2 instance #157
base: main
Are you sure you want to change the base?
Conversation
Okay I think this is actually working again and really ready for review! I'm gonna deliberately break the k8 YAML and make sure the test fails (it wouldn't have before) and then restore it. |
It's
|
@@ -0,0 +1,3 @@ | |||
echo "This is a uv project. Remember to 'uv run ...' everything" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooohhh
cicd/pulumi/uv.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a worry b/c dependabot wont check uv.lock files yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not ideal. But this dependency closure is pretty tiny - only a handful of packages in here. And it looks like dependabot is going to add uv this quarter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it looks good to me!
Pretty big (but useful!) change. Adds a GHA workflow step that in a fully automatic way:
It uses pulumi for infra, and relies on pulumi infra defined in the GL_Public AWS account.
It does NOT yet:
(Note: there is replication of #169 which improves the workflow YAML and validation thereof directly.)
(Note: this relies on resources defined in the
gl_public
account defined in the internalci-infra
repo.)