Support HTTPS with Self-Signed Certificates #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaise-muhirwa
commented
Oct 19, 2023
| groundlight = "0.11.0" | ||
| fastapi = "0.103.2" | ||
| pydantic = ">=2.0,<3.0.0" | ||
| groundlight = {git = "https://github.com/groundlight/python-sdk.git", rev = "disable-tls-verification"} |
There was a problem hiding this comment.
Currently pointing to this branch since the feature that supports disabling TLS verification is not yet merged into main in the SDK.
blaise-muhirwa
commented
Oct 19, 2023
| @@ -135,6 +138,9 @@ jobs: | |||
| with: | |||
| python-version: ${{ env.PYTHON_VERSION }} | |||
|
|
|||
| - name: Generate TLS certificate | |||
There was a problem hiding this comment.
Once I figure out how to optionally check for TLS certificate in NGINX config, I will remove this step since motion detection tests actually run just with HTTP.
blaise-muhirwa
commented
Oct 19, 2023
| @@ -0,0 +1,29 @@ | |||
| apiVersion: apps/v1 | |||
There was a problem hiding this comment.
All of this is also not necessary! Will get rid of it and remove any scripting that was setup to apply this deployment patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.