Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI improvements - autodiscover previews images, is more robust #27

Merged
merged 7 commits into from
Feb 9, 2024
Merged

CLI improvements - autodiscover previews images, is more robust #27

merged 7 commits into from
Feb 9, 2024

Conversation

robotrapta
Copy link
Member

A bit of refactoring in the CLI tools for preview & autodiscover so they're more robust and useful. Autodiscover will preview the images it finds with imgcat by default.

sunildkumar
sunildkumar approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@sunildkumar sunildkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! An extension of this might be to make autodiscover interactive and let the user see all of their cameras, and then input a digit that defines which camera to use for this execution of the program.

@robotrapta robotrapta merged commit fa5e071 into main Feb 9, 2024
3 checks passed
@robotrapta robotrapta deleted the cli-improvements branch February 9, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunildkumar sunildkumar sunildkumar approved these changes

@timmarkhuff timmarkhuff Awaiting requested review from timmarkhuff

@brandon-groundlight brandon-groundlight Awaiting requested review from brandon-groundlight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robotrapta @sunildkumar