Skip to content

Commit

Permalink
Re enable improvement test (#129)
Browse files Browse the repository at this point in the history
* temporarily disable tests

* Automatically reformatting code

* comment out whole test

* use pytest skip rather than comment

* Open the gates! Turn the tests back on!

* fix ask method quality

* overwrite merge overwriting fix

* fix other line

---------

Co-authored-by: Auto-format Bot <[email protected]>
  • Loading branch information
brandon-groundlight and Auto-format Bot authored Nov 7, 2023
1 parent a341333 commit 9b074df
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions test/integration/test_groundlight.py
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,6 @@ def test_submit_numpy_image(gl: Groundlight, detector: Detector):
assert is_valid_display_result(_image_query.result)


@pytest.mark.skip(reason="Detector improvement is incredibly flaky")
@pytest.mark.skipif(MISSING_PIL, reason="Needs pillow") # type: ignore
def test_detector_improvement(gl: Groundlight):
# test that we get confidence improvement after sending images in
Expand Down Expand Up @@ -526,7 +525,6 @@ def submit_noisy_image(image, label=None):
), f"The detector {detector} quality has not improved after two minutes q.v. {new_dog_query}, {new_cat_query}"


@pytest.mark.skip(reason="Detector improvement is incredibly flaky")
def test_ask_method_quality(gl: Groundlight, detector: Detector):
# asks for some level of quality on how fast ask_ml is and that we will get a confident result from ask_confident
fast_always_yes_iq = gl.ask_ml(detector=detector.id, image="test/assets/dog.jpeg", wait=0)
Expand All @@ -537,7 +535,7 @@ def test_ask_method_quality(gl: Groundlight, detector: Detector):
fast_iq = gl.ask_ml(detector=detector.id, image="test/assets/dog.jpeg", wait=0)
assert iq_is_answered(fast_iq)
confident_iq = gl.ask_confident(detector=detector.id, image="test/assets/dog.jpeg", wait=180)
assert confident_iq.result.confidence > IQ_IMPROVEMENT_THRESHOLD
assert confident_iq.result.confidence is None or (confident_iq.result.confidence > IQ_IMPROVEMENT_THRESHOLD)


def test_start_inspection(gl: Groundlight):
Expand Down

0 comments on commit 9b074df

Please sign in to comment.