Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a blog section on code.groundlight.ai and a blog post on framegrab #138

Merged
merged 9 commits into from
Dec 11, 2023
Merged

add a blog section on code.groundlight.ai and a blog post on framegrab #138

merged 9 commits into from
Dec 11, 2023

Conversation

blaise-muhirwa
Copy link
Contributor

This adds a blog in our docusaurus docs. The blog that I added currently looks like this:

Screenshot 2023-12-06 at 3 51 15 PM
Screenshot 2023-12-06 at 3 51 28 PM
Screenshot 2023-12-06 at 3 51 34 PM

tyler-romero
tyler-romero reviewed Dec 7, 2023
View reviewed changes
docs/blog/2023-12-06-framegrab.md Outdated
@@ -0,0 +1,175 @@
---
title: Announcing Groundlight's FrameGrab Library
description: Today, we are happy to announce FrameGrab 0.4.3.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: its a little funny for us to make a big blog post about version 0.4.3 specifically. Why didnt version 0.4.2 get a blog post??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the v0.4.3 specific features?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it feels like we should make this 0.5.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Today, we are happy to announce FrameGrab 0.4.3.
description: We'd like to introduce you to the FrameGrab library.

I agree. This is why I like the phrase "Introducing" framegrab. It's been around for a while, but now we're going to introduce you to it.

tyler-romero
tyler-romero approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@tyler-romero tyler-romero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor nits!

What makes it hard to change the url?

blaise-muhirwa and others added 3 commits December 7, 2023 13:50
@blaise-muhirwa @tyler-romero
accept suggested changes
667c4af 
Co-authored-by: Tyler Romero <[email protected]>
@blaise-muhirwa @tyler-romero
accept suggested change
3dbb6fa 
Co-authored-by: Tyler Romero <[email protected]>
@blaise-muhirwa @tyler-romero
accept suggested changes
fad5467 
Co-authored-by: Tyler Romero <[email protected]>
mjvogelsong
mjvogelsong approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@mjvogelsong mjvogelsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Blaise (and Tim)!

Just some nits in the wording -- mainly, I think this blog post has a technical audience, and that audience gets a little skeptical when we use words like "awesome", "great", and "extremely" when describing our own stuff.

docs/blog/2023-12-06-framegrab.md Outdated Show resolved Hide resolved
docs/blog/2023-12-06-framegrab.md Outdated
@@ -0,0 +1,175 @@
---
title: Announcing Groundlight's FrameGrab Library
description: Today, we are happy to announce FrameGrab 0.4.3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it feels like we should make this 0.5.0.

docs/blog/2023-12-06-framegrab.md Outdated Show resolved Hide resolved
docs/blog/2023-12-06-framegrab.md Outdated Show resolved Hide resolved
docs/blog/2023-12-06-framegrab.md Outdated Show resolved Hide resolved
docs/blog/2023-12-06-framegrab.md Show resolved Hide resolved
robotrapta
robotrapta approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@robotrapta robotrapta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some wording changes, but I love it!

docs/blog/2023-12-06-framegrab.md Outdated Show resolved Hide resolved
docs/blog/2023-12-06-framegrab.md Outdated
@@ -0,0 +1,175 @@
---
title: Announcing Groundlight's FrameGrab Library
description: Today, we are happy to announce FrameGrab 0.4.3.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Today, we are happy to announce FrameGrab 0.4.3.
description: We'd like to introduce you to the FrameGrab library.

I agree. This is why I like the phrase "Introducing" framegrab. It's been around for a while, but now we're going to introduce you to it.

docs/blog/2023-12-06-framegrab.md Outdated Show resolved Hide resolved
docs/blog/2023-12-06-framegrab.md Outdated Show resolved Hide resolved
@blaise-muhirwa blaise-muhirwa merged commit fc1bc45 into main Dec 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyler-romero tyler-romero tyler-romero approved these changes

@robotrapta robotrapta robotrapta approved these changes

@mjvogelsong mjvogelsong mjvogelsong approved these changes

@sunildkumar sunildkumar Awaiting requested review from sunildkumar

@brandon-groundlight brandon-groundlight Awaiting requested review from brandon-groundlight

@timmarkhuff timmarkhuff Awaiting requested review from timmarkhuff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blaise-muhirwa @mjvogelsong @tyler-romero @robotrapta