Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register markers to avoid pytest warnings #289

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Conversation

CoreyEWood
Copy link
Contributor

Previously we'd get a bunch of warnings like this when running tests:

test/integration/test_groundlight.py:373
  /home/ubuntu/ptdev/python-sdk/test/integration/test_groundlight.py:373: PytestUnknownMarkWarning: Unknown pytest.mark.skip_for_edge_endpoint - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.skip_for_edge_endpoint(reason="The edge-endpoint does not support passing detector metadata.")

According to the docs, unregistered markers will always produce these warnings. By registering our two custom markers, we don't get these warnings anymore.

Copy link
Collaborator

@brandon-groundlight brandon-groundlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoreyEWood CoreyEWood merged commit 8f798c5 into main Dec 6, 2024
9 checks passed
@CoreyEWood CoreyEWood deleted the fix-pytest-warnings branch December 6, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants