Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LEPTON_SDK.c #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mellbratt
Copy link

Had to make these small changes for it to compile on macOS Catalina 10.15.7 and Qt 5.15.2

Had to make these changes for it to compile on macOS Catalina 10.15.7 and Qt 5.15.2
@kekiefer
Copy link
Member

Hi! Thanks for the PR.

I believe that this change is syntactically correct, but it appears like it will create an infinite recursion at runtime when the function calls itself.

The LEP_GetAttribute function still needs to call the "concrete" implementation of UVC_GetAttribute, defined in src/leptonvariation.cpp, which does the actual communication with the device.

If you provide the compile error message, I might be able to offer a bit more help.

@mellbratt
Copy link
Author

mellbratt commented Jan 12, 2021

Oops,

Yes I'm new at this. ;D Did as suggested in the error message below and it would then run. Didn't realise it would cause other problems...

EDIT: Tried to fix the line breaks in the error message for clarity

/Users/xxxxx/Downloads/GetThermal-master/lepton_sdk/Src/LEPTON_SDK.c:142: error: implicit declaration of function 'UVC_GetAttribute' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
../GetThermal-master/lepton_sdk/Src/LEPTON_SDK.c:142:18: error: implicit declaration of function 'UVC_GetAttribute' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
result = UVC_GetAttribute(portDescPtr, commandID, attributePtr, attributeWordLength); ^
../GetThermal-master/lepton_sdk/Src/LEPTON_SDK.c:142:18: note: did you mean 'LEP_GetAttribute'?
../GetThermal-master/lepton_sdk/Src/LEPTON_SDK.c:102:12: note: 'LEP_GetAttribute' declared here
LEP_RESULT LEP_GetAttribute(LEP_CAMERA_PORT_DESC_T_PTR portDescPtr, ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants