-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for sleuth and zipkin integration #264 #568
base: master
Are you sure you want to change the base?
Conversation
Sorry for the late response. I have been on vacation. This looks good to me. I will do a thorough review in the next few days. |
Could you please provide a |
here is the docker command to install zipkin
then open http://127.0.0.1:9411/ you could see the zipkin ui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masayoshi-louis is right. These beans will be created automatically by this library and thus don't need to be created in the example projects again.
@haochencheng Sorry for the delay with my reviews. I'm currently very busy and don't have any spare time.
...pc-client/src/main/java/net/devh/boot/grpc/examples/cloud/client/GrpcSleuthClientConfig.java
Outdated
Show resolved
Hide resolved
...pc-client/src/main/java/net/devh/boot/grpc/examples/cloud/client/GrpcSleuthClientConfig.java
Outdated
Show resolved
Hide resolved
...pc-server/src/main/java/net/devh/boot/grpc/examples/cloud/server/GrpcSleuthServerConfig.java
Outdated
Show resolved
Hide resolved
...pc-server/src/main/java/net/devh/boot/grpc/examples/cloud/server/GrpcSleuthServerConfig.java
Outdated
Show resolved
Hide resolved
It's ok.These beans are redundant,i add these beans want people know that them can customer the beans.The example should by simple and concise. I will do a recheck and remove these benas. |
Hello.I see #264 is marked help wanted .
I add examples:cloud-sleuth-zipkin-grpc-client and examples:cloud-sleuth-zipkin-grpc-server which integration sleuth and
zipkin .