drop usage of obsolete oauth2.Context

[adg]

No description provided.

[dsymonds]

LGTM

[iamqizhao]

LGTM, waiting for Travis result before merging ...

On Wed, Mar 4, 2015 at 7:47 PM, David Symonds [email protected]
wrote:

LGTM

—
Reply to this email directly or view it on GitHub
#100 (comment).

[adg]

Travis reports this failure:

../../../google.golang.org/grpc/credentials/credentials.go:206: undefined: oauth2.Context

But this CL specifically removes oauth2.Context from that line in that file.

Looking at the build log, it looks like the script that fetches and tests the code does not apply the pull request patch between running go get and go test.

[iamqizhao]

On Wed, Mar 4, 2015 at 7:57 PM, Andrew Gerrand [email protected]
wrote:

Travis reports this failure:

../../../google.golang.org/grpc/credentials/credentials.go:206: undefined: oauth2.Context

But this CL specifically removes oauth2.Context from that line in that
file.

Looking at the build log, it looks like the script that fetches and tests
the code does not apply the pull request patch between running go get and go
test.

This sounds very serious bug ...

Should I go ahead merging your PR now and leave this issue later?

—
Reply to this email directly or view it on GitHub
#100 (comment).

[adg]

Now I can't find the build failure log from travis?! It just disappeared.

[iamqizhao]

because I restarted it ...

On Wed, Mar 4, 2015 at 8:10 PM, Andrew Gerrand [email protected]
wrote:

Now I can't find the build failure log from travis?! It just disappeared.

—
Reply to this email directly or view it on GitHub
#100 (comment).

[iamqizhao]

now it tries to fetch the pull request which was merged and fails ...

On Wed, Mar 4, 2015 at 8:12 PM, Qi Zhao [email protected] wrote:

because I restarted it ...

On Wed, Mar 4, 2015 at 8:10 PM, Andrew Gerrand [email protected]
wrote:

Now I can't find the build failure log from travis?! It just disappeared.

—
Reply to this email directly or view it on GitHub
#100 (comment).