Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpcsync : Remove OnceFunc #8049

Merged

Conversation

ashishksrivastava
Copy link
Contributor

@ashishksrivastava ashishksrivastava commented Jan 29, 2025

Remove grpcsync.OnceFunc as OnceFunc is part of standard sync lib starting go1.21

Fixes: #8016
RELEASE NOTES: N/A

Copy link

linux-foundation-easycla bot commented Jan 29, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ashishksrivastava / name: Ashish Srivastava (9ce5016)

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (73e4470) to head (9ce5016).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8049      +/-   ##
==========================================
+ Coverage   82.13%   82.24%   +0.11%     
==========================================
  Files         384      383       -1     
  Lines       38927    38922       -5     
==========================================
+ Hits        31971    32013      +42     
+ Misses       5618     5583      -35     
+ Partials     1338     1326      -12     
Files with missing lines Coverage Δ
balancer_wrapper.go 87.32% <100.00%> (+1.02%) ⬆️
internal/xds/bootstrap/tlscreds/bundle.go 82.45% <100.00%> (ø)
orca/producer.go 95.53% <100.00%> (ø)
server.go 82.78% <100.00%> (-0.08%) ⬇️
xds/internal/xdsclient/authority.go 76.87% <100.00%> (ø)
xds/internal/xdsclient/clientimpl.go 79.16% <100.00%> (ø)
xds/internal/xdsclient/pool.go 80.45% <100.00%> (ø)
xds/internal/xdsclient/transport/lrs/lrs_stream.go 75.63% <100.00%> (+5.07%) ⬆️

... and 20 files with indirect coverage changes

Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, adding a second reviewer.

@arjan-bal arjan-bal requested a review from easwars January 29, 2025 08:35
@arjan-bal arjan-bal changed the title Remove grpcsync.OnceFunc grpcsync : Remove OnceFunc Jan 29, 2025
@easwars easwars assigned ashishksrivastava and unassigned easwars Jan 29, 2025
@ashishksrivastava ashishksrivastava merged commit e4a0dfd into grpc:master Jan 30, 2025
15 checks passed
@ashishksrivastava ashishksrivastava deleted the aks-remove-grpcsync-oncefunc branch January 30, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanup: Remove grpcsync.OnceFunc
3 participants