Merge pull request #2084 from murgatroid99/grpc-js_disable_session_me…

…mory_limit grpc-js: Disable per-session memory limit by default
grpc · Apr 11, 2022 · 7664a49 · 7664a49
2 parents fc54c15 + 12c58c2
commit 7664a49
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/grpc-js/package.json b/packages/grpc-js/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@grpc/grpc-js",
-  "version": "1.6.2",
+  "version": "1.6.3",
   "description": "gRPC Library for Node - pure JS implementation",
   "homepage": "https://grpc.io/",
   "repository": "https://github.com/grpc/grpc-node/tree/master/packages/grpc-js",

diff --git a/packages/grpc-js/src/subchannel.ts b/packages/grpc-js/src/subchannel.ts
@@ -406,6 +406,12 @@ export class Subchannel {
       connectionOptions.maxSessionMemory = this.options[
         'grpc-node.max_session_memory'
       ];
+    } else {
+      /* By default, set a very large max session memory limit, to effectively
+       * disable enforcement of the limit. Some testing indicates that Node's
+       * behavior degrades badly when this limit is reached, so we solve that
+       * by disabling the check entirely. */
+      connectionOptions.maxSessionMemory = Number.MAX_SAFE_INTEGER;
     }
     let addressScheme = 'http://';
     if ('secureContext' in connectionOptions) {