excluded client streaming from type

grpc · Jan 30, 2024 · bef964a · bef964a
1 parent f338988
commit bef964a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/packages/grpc-js/src/object-stream.ts b/packages/grpc-js/src/object-stream.ts
@@ -49,9 +49,9 @@ export interface IntermediateObjectWritable<T> extends Writable {
 }
 
 export interface ObjectWritable<T> extends IntermediateObjectWritable<T> {
-  _write(chunk: T | Buffer, encoding: string, callback: Function): void;
-  write(chunk: T | Buffer, cb?: Function): boolean;
-  write(chunk: T | Buffer, encoding?: any, cb?: Function): boolean;
+  _write(chunk: T, encoding: string, callback: Function): void;
+  write(chunk: T, cb?: Function): boolean;
+  write(chunk: T, encoding?: any, cb?: Function): boolean;
   setDefaultEncoding(encoding: string): this;
   end(): ReturnType<Writable['end']> extends Writable ? this : void;
   end(

diff --git a/packages/grpc-js/src/server-call.ts b/packages/grpc-js/src/server-call.ts
@@ -90,20 +90,32 @@ export type ServerSurfaceCall = {
   getPath(): string;
 } & EventEmitter;
 
+export type ServerWritableBuffer<ResponseType> = {
+  _write(
+    chunk: ResponseType | Buffer,
+    encoding: string,
+    callback: Function
+  ): void;
+  write(chunk: ResponseType | Buffer, cb?: Function): boolean;
+  write(chunk: ResponseType | Buffer, encoding?: any, cb?: Function): boolean;
+};
+
 export type ServerUnaryCall<RequestType, ResponseType> = ServerSurfaceCall & {
   request: RequestType;
 };
 export type ServerReadableStream<RequestType, ResponseType> =
   ServerSurfaceCall & ObjectReadable<RequestType>;
 export type ServerWritableStream<RequestType, ResponseType> =
   ServerSurfaceCall &
-    ObjectWritable<ResponseType> & {
+    ObjectWritable<ResponseType> &
+    ServerWritableBuffer<ResponseType> & {
       request: RequestType;
       end: (metadata?: Metadata) => void;
     };
 export type ServerDuplexStream<RequestType, ResponseType> = ServerSurfaceCall &
   ObjectReadable<RequestType> &
-  ObjectWritable<ResponseType> & { end: (metadata?: Metadata) => void };
+  ObjectWritable<ResponseType> &
+  ServerWritableBuffer<ResponseType> & { end: (metadata?: Metadata) => void };
 
 export class ServerUnaryCallImpl<RequestType, ResponseType>
   extends EventEmitter